switch to lowercase 'plotly' require.js dependency #4640
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plots.jl makes the RequiresJS dependency uppercase 'Plotly' but plotly.py and PlotlyJS have it lowercase 'plotly'. If you export figures from each of them and try to splice them into the same parent document, it makes it really hard to resolve the dependency (since to my very noob knowledge, you can't load the same library under two different names). This PR makes Plots.jl consistent with the others.
Have not tested extensively beyond my simple cases so someone that knows what they're doing should definitely verify this.