Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to lowercase 'plotly' require.js dependency #4640

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

marius311
Copy link
Contributor

Plots.jl makes the RequiresJS dependency uppercase 'Plotly' but plotly.py and PlotlyJS have it lowercase 'plotly'. If you export figures from each of them and try to splice them into the same parent document, it makes it really hard to resolve the dependency (since to my very noob knowledge, you can't load the same library under two different names). This PR makes Plots.jl consistent with the others.

Have not tested extensively beyond my simple cases so someone that knows what they're doing should definitely verify this.

consistent with plotly.py and PlotlyJS.jl
@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Base: 90.80% // Head: 90.80% // No change to project coverage 👍

Coverage data is based on head (6da30da) compared to base (2eb315f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4640   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          41       41           
  Lines        8778     8778           
=======================================
  Hits         7971     7971           
  Misses        807      807           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeastyBlacksmith BeastyBlacksmith merged commit 54a215f into JuliaPlots:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants