Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR: use correct attribute for axis color #1787

Merged
merged 1 commit into from
Oct 14, 2018
Merged

GR: use correct attribute for axis color #1787

merged 1 commit into from
Oct 14, 2018

Conversation

greimel
Copy link
Contributor

@greimel greimel commented Oct 13, 2018

using Plots
using StatPlots, DataFrames

test = DataFrame(
    x = rand(20),
    y = rand(20),
    grp = rand(["g 1"; "g 2"], 20)
 )

gr()
@df test scatter(:x, :y, group=:grp, xlab="x", ylab="y",
                  foreground_color_axis=:blue,
                  foreground_color_border=:green)

Before:

scatter_gr_before

After:
scatter_gr_after

Now it matches behavior for pyplot(), I can't reproduce right now, because my PyCall.jl doesn't build.

This will be helpful for JuliaPlots/PlotThemes.jl/pull/30

As an aside, the attribute names could be changed so something more intuitive, IMO.

@daschw
Copy link
Member

daschw commented Oct 14, 2018

Thanks @greimel !

@daschw daschw merged commit cbc965d into JuliaPlots:master Oct 14, 2018
@greimel greimel deleted the gre/gr-axis-color branch October 14, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants