Simpler way to fix use with Interact in IJulia on page refresh #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See JuliaGizmos/Interact.jl#115 for more context
JobJob
force-pushed
the
ijulia_interact_refresh2
branch
from
80c818c to
9aef33f
Compare
This was referenced Nov 1, 2016
|
Excellent, I like this change. Thanks for re-working it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JuliaGizmos/Interact.jl#115 for more context
Tl;dr: on page refresh the Jupyter front end clears all registered comms, so the
_ijulia_eval_commheld by PlotlyJS becomes stale. This change ensures a new global Comm is created every timeJupiterDisplayis called, which stops the old Comm from becoming stale on page refresh.