Remove kind field for GenericTrace and Shape.
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes implementation of `JSON._print` just forward on to the fields field
|
Also cc @tbreloff. I think I did this in a backwards compatible way as long as you don't try to access the I ran it through ExamplePlots and it seemed to work ok. If you notice that anything has broken please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so
JSON._print(..., hf::HasFields, ...) = JSON._print(..., hf.fields, ...)instead of re-implementing most of the object serialization forShapeandGenericTracetypes.Ref: JuliaLang/METADATA.jl#5427
Is there a way to avoid overloading
JSON._print(hinted at by @TotalVerb here)? I don't think definingJSON.jsonwill work here for reasons described herecc @TotalVerb, @tkelman