Fix precompilation of packages depending on PlotlyJS #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jul 11, 2023
vtjnash
reviewed
Jul 11, 2023
Co-authored-by: Jameson Nash <[email protected]>
Co-authored-by: Jameson Nash <[email protected]>
|
I'm excited for this pull request to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Julia v1.10, using PlotlyJS.jl as a dependency of any other package causes the precompilation of this other package to be stuck, as explained in JuliaLang/julia#50505. This PR fixes that.
The root cause of the issue was JuliaLang/julia#48506. To be honest, I'm not sure I understand why the behavior of the
__init__function of PlotlyJS should livelock the precompilation of other packages... but I was inspired by https://github.com/JuliaDebug/Cthulhu.jl/pull/343/files and https://github.com/JuliaImages/ImageView.jl/pull/279/files, which targeted similar issues, for this PR.