Update to latest WebIO.

[twavv]

This will not pass on CI until JuliaRegistries/General#1473 is merged.

This fixes #278.

[twavv]

Oh, @sglyon you also include a Manifest.toml file. Can we get rid of that? I don't think it's common to include that with packages (it's also causing CI to fail because I didn't update it).

[sglyon]

Thanks @travigd

I tested this out and I do get plots in the jupyter notebook, but I couldn't replicate the issues from #278

Can anyone verify that this does indeed fix #278? cc @halleysfifthinc @JobJob @DhruvaSambrani @jingpengw @ghuba

[sglyon]

@travigd I removed the Manifest.toml file from the master branch. Would you be willing to rebase this PR on master so we can check CI?

[DhruvaSambrani]

I did

]up
add https://github.com/travigd/PlotlyJS.jl#upgrade-webio-0.8.6
build
precompile

Started Jupyter notebook and ran

using PlotlyJS
plot([1,2,3,4,5])

This gave the following output

┌ Warning: Please upgrade Blink for a smoother integration with WebIO.
│   caller = ip:0x0
└ @ Core :-1
┌ Warning: Accessing `scope.id` is deprecated, use `scopeid(scope)` instead.
│   caller = ip:0x0
└ @ Core :-1
[The Graph rendered correctly]

The Blink warning should go once you merge I suppose.
The scope.id warning could be resolved by doing a FindReplace of all scope.id to scopeid(scope).

But

using Plots
plotlyjs()
plot([1,2,3,4,5])

Gave the old "WebIO not found" error. But I suppose once the new version is released, this issue should go.

So yes, it's working!😄😄

[twavv]

The scopeid issue is originating form JSExpr I think. We need to release a new version of that.

[DhruvaSambrani]

The scopeid issue is originating form JSExpr I think. We need to release a new version of that.

Shall I make an issue there if you're sure?

[sglyon]

I did check PlotlyJS.jl and the scopeid issue is not in this repo. Not sure where it is, but it isn't here 😆

[DhruvaSambrani]

So is this ready to be published?

[twavv]

I'm not entirely sure it's in JSExpr but that's a strong hunch. I will rebase this later and this it will be ready.