Matching plotly.js semantics in restyle! #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow lots of changes! Lets merge and figure it out. |
|
Travis gives a green light, let's do it! |
sglyon
added a commit
that referenced
this pull request
Mar 9, 2016
Matching plotly.js semantics in restyle!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the changeset that should fix #23.
It ended up being quite a bit more complicated than I initially expected as the semantics of plotly.js are a bit complicated.
I have tests for the cases I could think of and the tests show that we do match semantics on those cases.
cc @tbreloff