new rebase of color-libraries #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkborregaard
commented
Feb 21, 2017
| end | ||
|
|
||
| getindex(cl::ColorLibrary, key::Symbol) = getgradient(key, cl) | ||
|
|
There was a problem hiding this comment.
Might be nice with a setindex function as well to easily add gradients (quite useful for PlotThemes, I'd imagine)
|
merge when you're comfortable! |
|
Thanks! I still only have push rights to StatPlots though :-) |
|
Try again? |
|
Wohoo! :-) |
This was referenced Feb 26, 2017
|
There are now PRs on PlotThemes and Plots that resolves the conflict with using themes. |
Simplify by disallowing directly passing color library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copy-pasted the changes over manually