Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a list of vectors rather than a NaN sepearted list to denote shapes #146

Merged
merged 16 commits into from
Jun 3, 2021
Merged

Use a list of vectors rather than a NaN sepearted list to denote shapes #146

merged 16 commits into from
Jun 3, 2021

Conversation

JackDevine
Copy link
Member

Fixes #145 also includes some misc tidying changes

@JackDevine JackDevine mentioned this pull request May 20, 2021
Closed
@JackDevine JackDevine mentioned this pull request May 21, 2021
Merged
@BeastyBlacksmith
Copy link
Member

BeastyBlacksmith commented May 21, 2021 •
edited
Loading

Running the tests using this branch locally on julia 1.0.5 is actually fine on my machine.

Plots resolve to version 1.4.3

BeastyBlacksmith
BeastyBlacksmith reviewed May 21, 2021
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
@BeastyBlacksmith
Copy link
Member

can you rebase on master?

@BeastyBlacksmith
Copy link
Member

So now we got one version that works on 1.0 and one version that works on 1.6. I'd suggest to set julia compat to 1.6 here.
Unless you want to fix 1.0, which is also fine with me, but I didn't look into that, might require a patch release for Plots 1.4

@BeastyBlacksmith
Copy link
Member

@JackDevine what do you think? I'd like to get this merged for JuliaPlots/Plots.jl#3519

@JackDevine
Copy link
Member Author

Sorry for the long delay.

It is a little unfortunate to drop support for v1.0, but I guess that I am OK with that. Am I right that we are also planning on dropping Julia v1.0 support for StatsPlots too?

@BeastyBlacksmith
Copy link
Member

As far as I can see StatsPlots never had julia 1.0 in its compat entry and is currently only tested on julia 1.6

@BeastyBlacksmith BeastyBlacksmith merged commit 92c6d10 into JuliaPlots:master Jun 3, 2021
@JackDevine JackDevine mentioned this pull request Aug 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeastyBlacksmith BeastyBlacksmith BeastyBlacksmith left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Can no longer set individual node colours
2 participants
@JackDevine @BeastyBlacksmith