Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

fix ssao rendering issue in LScene and update lighting docs #624

Merged
merged 5 commits into from
Feb 4, 2021

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Feb 3, 2021

Docs update for JuliaPlots/GLMakie.jl#107.

Also fixes this issue with ssao in figures:
Screenshot from 2021-02-03 10-33-40

Currently SSAO distinguishes between scenes using a stencil buffer that is only written to if scene.clear = true. So I changed the default for LScene. This means an LScene will not render over other plots that are rendered before.

I tried a bunch of variations of

fig = Figure()
Menu(fig[1, 1])
s = LScene(fig[2, 1])
scatter!(s, rand(10))

including 3d plots with ssao, 2d without, 2d without fxaa and different orders of operations (Menu-scene-plot, scene-menu-plot, scene-plot-menu). The Menu is always on top when opened, which is what I thought might break.

This also means that backgroundcolor now works for LScene.

@ffreyer
Copy link
Collaborator Author

ffreyer commented Feb 3, 2021

GLMakie is one version behind in the docs build...?

@SimonDanisch
Copy link
Member

You should be able to bump the version in AbstractPlotting\docs\Project.toml

@SimonDanisch
Copy link
Member

SimonDanisch commented Feb 3, 2021

hm, or so I thought...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants