Skip to content
This repository has been archived by the owner on Jul 13, 2021. It is now read-only.

Change _primary_resolution to use system calls on Apple computers #563

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

ndinsmore
Copy link

This fixes primary_resolution() so that it returns that actual current display setting. It also changes the call to use system calls which should be faster.

@SimonDanisch
Copy link
Member

Awesome, thanks a lot! :)
Do you happen to know, how portable this is between OSX versions, considering the _CoreGraphics path is hardcoded?

@ndinsmore
Copy link
Author

Simon CoreGraphics has been a core framework since 10.8. and aple list support as 10.8+. I changed the library string to allow the system to find the path. Should be portable now.

@SimonDanisch
Copy link
Member

Cool, whatever works! ;) I just have no way to test this, and the CI neither!

@ndinsmore
Copy link
Author

I think that this is ready to go.

@SimonDanisch
Copy link
Member

Thanks!

@SimonDanisch SimonDanisch merged commit 0449045 into JuliaPlots:master Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants