Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVMLibUnwind] Update #9241

Closed
wants to merge 5 commits into from
Closed

Conversation

IanButterworth
Copy link
Member

No description provided.

@IanButterworth
Copy link
Member Author

The 2nd patch can't be applied.
I don't have lsdiff locally (macos) and the CI isn't showing the diff

  | 2024-08-12 16:53:08 CEST | [14:53:08] Attempting to apply 0001-unwind-prologue-epilogue.patch...
  | 2024-08-12 16:53:08 CEST | [14:53:08]  ---> for f in $WORKSPACE/srcdir/patches/*.patch
  | 2024-08-12 16:53:08 CEST | [14:53:08]  ---> echo "Applying patch ${f}"
  | 2024-08-12 16:53:08 CEST | [14:53:08]  ---> atomic_patch -p2 ${f}
  | 2024-08-12 16:53:08 CEST | [14:53:08] Attempting to apply 0002-force-dwarf.patch...
  | 2024-08-12 16:53:08 CEST | [14:53:08] Patch 0002-force-dwarf.patch could not be applied! Reverting...
  | 2024-08-12 16:53:08 CEST | [14:53:08]  ---> atomic_patch -p2 ${f}
  | 2024-08-12 16:53:08 CEST | [14:53:08]  ---> atomic_patch -p2 ${f}
  | 2024-08-12 16:53:08 CEST | [14:53:08] Previous command exited with 1
  | 2024-08-12 16:53:08 CEST | [14:53:08] Child Process exited, exit code 1

@ararslan
Copy link
Member

@IanButterworth, I pushed a commit to your branch that updates the patch that failed to apply.

@ararslan
Copy link
Member

ararslan commented Aug 26, 2024

macOS AArch64 failure:

ld64.lld: error: undefined symbol: __libunwind_Registers_arm64_jumpto
>>> referenced by CMakeFiles/unwind_shared_objects.dir/libunwind.cpp.o:(symbol libunwind::UnwindCursor<libunwind::LocalAddressSpace, libunwind::Registers_arm64>::jumpto()+0x4)

ld64.lld: error: undefined symbol: __unw_getcontext
>>> referenced by CMakeFiles/unwind_shared_objects.dir/UnwindLevel1.c.o:(symbol _Unwind_RaiseException+0x1c)
>>> referenced by CMakeFiles/unwind_shared_objects.dir/UnwindLevel1.c.o:(symbol _Unwind_Resume+0x18)
>>> referenced by CMakeFiles/unwind_shared_objects.dir/UnwindLevel1.c.o:(symbol _Unwind_ForcedUnwind+0x24)
>>> referenced 3 more times
clang: error: linker command failed with exit code 1 (use -v to see invocation)

macOS x86_64 is the same but with Registers_x86_64.

Windows x86_64:

/opt/x86_64-w64-mingw32/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld: CMakeFiles/unwind_shared.dir/objects.a(Unwind-seh.cpp.obj):Unwind-seh.cpp:(.text+0x548): undefined reference to `__unw_getcontext'
/opt/x86_64-w64-mingw32/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld: CMakeFiles/unwind_shared.dir/objects.a(Unwind-seh.cpp.obj):Unwind-seh.cpp:(.text+0x640): undefined reference to `__unw_getcontext'
/opt/x86_64-w64-mingw32/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld: CMakeFiles/unwind_shared.dir/objects.a(UnwindLevel1-gcc-ext.c.obj):UnwindLevel1-gcc-ext.c:(.text+0x109): undefined reference to `__unw_getcontext'
/opt/x86_64-w64-mingw32/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld: CMakeFiles/unwind_shared.dir/objects.a(UnwindLevel1-gcc-ext.c.obj):UnwindLevel1-gcc-ext.c:(.text+0x176): undefined reference to `__unw_getcontext'
/opt/x86_64-w64-mingw32/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld: CMakeFiles/unwind_shared.dir/objects.a(UnwindLevel1-gcc-ext.c.obj):UnwindLevel1-gcc-ext.c:(.text+0x1d9): undefined reference to `__unw_getcontext'
collect2: error: ld returned 1 exit status

@giordano
Copy link
Member

Superseded by #9861

@giordano giordano closed this Nov 24, 2024
@giordano giordano deleted the ib/llvmlibunwind_update branch November 24, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants