[LLVM] Add LLVM_full, LLVM_full_assert 19 recipes #9204
Conversation
L/LLVM/common.jl
Outdated
| @@ -20,6 +20,7 @@ const llvm_tags = Dict( | |||
| v"16.0.6" => "499f87882a4ba1837ec12a280478cf4cb0d2753d", # julia-16.0.6-2 | |||
| v"17.0.6" => "0007e48608221f440dce2ea0d3e4f561fc10d3c6", # julia-17.0.6-5 | |||
| v"18.1.7" => "ed30d043a240d06bb6e010a41086e75713156f4f", # julia-18.1.7-2 | |||
| v"19.0.0" => "6c8f4c12da7b3ac3d45e9fc9f68e2da7f559cf76", # julia-release/19.x | |||
There was a problem hiding this comment.
Reminder: we need to create the git tag on the commit we will eventually use here.
There was a problem hiding this comment.
For the record, git tag created: https://github.com/JuliaLang/llvm-project/releases/tag/julia-19.1.1-0
|
Not sure why the assert build can't find bundled. |
|
You need to either follow symlinks https://docs.binarybuilder.org/stable/reference/#BinaryBuilderBase.DirectorySource or not use symlinks |
I don't understand what changed between the llvm 18 build that requires changing anything. |
|
https://github.com/Zentrik/Yggdrasil/blob/4a3cf630b50ce9c2d4c06770ebc1f7b3678fbe9e/L/LLVM/LLVM_full_assert%4019/bundled isn't a symlink, but a file whose content is the path of the symlink. |
|
Looks like it's building nicely with some commits reverted, the reverts are:
Also, the problems on non windows seemed to get fixed by these reverts. I would guess the darwin issues were fixed by Zentrik/llvm-project@e5a7644. I guess issues need to be filed and smaller fixes can probably be found. |
|
LLVM 19.1 has been released: https://discourse.llvm.org/t/llvm-19-1-0-released/81285 |
|
Yes, yesterday I rebased https://github.com/JuliaLang/llvm-project/commits/julia-release/19.x/ on top of 19.1.0. @Zentrik I see you opened a few tickets upstream about all the issues you faced. What do you suggest to do? Wait a few days if there's any movement there? It has been a few weeks already though.... Should we revert the offending commits in our fork for the time being? A proper resolution upstream would definitely be a better outcome though, diverging too much from upstream is problematic. |
|
I'll make some prs upstream and to our fork. Just haven't had the time. |
A restart will probably fix it, llvm/llvm-project#107687. |
|
LLVM 19.1.1 has been released https://discourse.llvm.org/t/llvm-19-1-1-released/82321 |
|
Did this fail to build or is llvm taking too long to clone? |
|
I cancelled them because libgit2 is insufferably slow, I fetched the repos manually with CLI git on the build machine with to make this go (I put the command here so that I remember next time) |
|
I suspect llvm/llvm-project#110382 is an issue in LLVM 19 as well so probably good to wait a couple days to see if it can get fixed. |
|
@Zentrik the ittapi patch looks broken |
|
yh JuliaLang/llvm-project#36 breaks the git cloning as ${PROJECT_BINARY_DIR} exists probably |
Co-authored-by: Mosè Giordano <[email protected]>
|
@Zentrik I still need to create the tag, but apart from that, is this now ready to go or are there other things we should wait for? |
I think this is ready to go. |
|
Thank you so much for all your work! |
* [LLVM] Add LLVM_full, LLVM_full_assert 19 recipes * Update patch * Test fixes * Test another fix * Try less targeted fix * Remove assert bundled * Add assert bundled * Adapt to llvm/llvm-project#89628 * Workaround llvm/llvm-project#106899 * Include less patches to llvm * Fix `DMLIR_SRC_SHARDER_TABLEGEN` * Just set `LLVM_NATIVE_TOOL_DIR` instead * Trigger rebuilds * Build off of Julia Fork * Fix tag * Set correct version * Set correct version * Update L/LLVM/common.jl * Update L/LLVM/common.jl * [LLVM] Upgrade to v19.1.1 * Bump LLVM version * Apply suggestions from code review * Bump LLVM Co-authored-by: Mosè Giordano <[email protected]> * rebuild * rebuild --------- Co-authored-by: Zentrik <[email protected]> Co-authored-by: Mosè Giordano <[email protected]> Co-authored-by: Mosè Giordano <[email protected]>
No description provided.