Add Maximum Independent Set library #8337
Conversation
|
The upstream makefile seems to have |
| products, | ||
| dependencies, | ||
| julia_compat = "1.9"; | ||
| preferred_gcc_version=v"11") |
There was a problem hiding this comment.
Is GCC 11 really needed? It looks like C++17 is used, which I think is available starting in GCC 7. In general, it is better to use as old a GCC version to build as possible because that ensures the best compatibility for the library.
There was a problem hiding this comment.
According to https://gcc.gnu.org/projects/cxx-status.html#cxx17 full support for c++17 is introduced as for g++-9. I will modify the line accordingly
| platforms = supported_platforms() | ||
| filter!(t -> os(t) in ["linux"], platforms) | ||
| filter!(t -> arch(t) == "x86_64", platforms) | ||
| filter!(t -> isnothing(libc(t)) || libc(t) == "glibc", platforms) |
There was a problem hiding this comment.
This is a slightly awkward way of just specifying the one platform, but it works. Out of curiosity though, is there a reason to not build on the other platforms?
There was a problem hiding this comment.
The makefile is a hard-coded, hand-written one. It only works on linux for now. I will work on creating a cmake script to enable cross-compile later this week
There was a problem hiding this comment.
I am testing a cmake build and will see if I can get to coompile on more platforms
Uses cmake more platforms preferred_gcc_version set to v9
imciner2
changed the title
Originally I had considered adding the wrapper within the C++ lib but ultimately decided to decouple both things, so I removed all references to libcxxwrap. I will create a separate wrapper package |
There was a problem hiding this comment.
If you link to libjulia you really must follow what other packages do here, see for example: https://github.com/JuliaPackaging/Yggdrasil/blob/5dd8bee7317d0c5d0f797ae2328a069890eda5c4/L/libsingular_julia/build_tarballs.jl, since julia itself breaks the ABI in each minor release.
Highlights are
Yggdrasil/L/libsingular_julia/build_tarballs.jl
Lines 39 to 44 in 5dd8bee
(without the exclusion of Windows, if it isn't relevant for your case)
| platforms = supported_platforms(; | ||
| exclude=[Platform("i686", "linux"; libc = "musl") | ||
| ] | ||
| ) |
There was a problem hiding this comment.
https://buildkite.com/julialang/yggdrasil/builds/9118#018e62ae-0e18-4c32-bb7b-99ef8051ce83/663-878
┌ Warning: /cache/build/yggy-amdci7-15/julialang/yggdrasil/M/MaximumIndependentSet/build/x86_64-linux-gnu/clphCAVm/x86_64-linux-gnu-libgfortran5-cxx11/destdir/lib/libmis.so contains std::string values! This causes incompatibilities across the GCC 4/5 version boundary. To remedy this, you must build a tarball for both GCC 4 and GCC 5. To do this, immediately after your `platforms` definition in your `build_tarballs.jl` file, add the line:
│
│ platforms = expand_cxxstring_abis(platforms)
└ @ BinaryBuilder.Auditor /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilder/L8tBh/src/auditor/compiler_abi.jl:247
| platforms = supported_platforms(; | |
| exclude=[Platform("i686", "linux"; libc = "musl") | |
| ] | |
| ) | |
| platforms = supported_platforms(; exclude=p->libc(p)=="musl" && arch(p)=="i686") | |
| platforms = expand_cxxstring_abis(platforms) |
There was a problem hiding this comment.
I see. I believe I implemented all the changes suggested (except for the last one that clashes with on of the other suggestions above)
|
I forgot you need also Yggdrasil/L/libsingular_julia/build_tarballs.jl Lines 6 to 9 in 5dd8bee |
Yep indeed without that the compiler complains about that UUID. Thank you for pointing out to the solution (or more like a workaround apparently) |
Tarballs for MaximumIndependentSet (originally in C++)