-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenBLASConsistentFPCSR #6215
Merged
giordano
merged 13 commits into
JuliaPackaging:master
from
orkolorko:OpenBLASConsistentFPCSR
Feb 9, 2023
Merged
Added OpenBLASConsistentFPCSR #6215
giordano
merged 13 commits into
JuliaPackaging:master
from
orkolorko:OpenBLASConsistentFPCSR
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd only use the latest version, there's little point in building all previous ones. |
Ok, even if it seems that this flag is supported on aarch64 I will work to exclude unsupported platforms. |
@giordano the compilation went through without any problems, but I needed to restrict to x86_64 |
Thanks for your contribution! |
Thank you @giordano! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a package OpenBLASConsistentFPCSR, which is nothing else than OpenBLAS
compiled with the
CONSISTENT_FPCSR=1
flag enabled, following issues#6214
and
JuliaIntervals/IntervalLinearAlgebra.jl#131
This flag controls the fact that, as the thread pool is started, all the threads have the same rounding mode; this flag is not implemented by default since in principle this may affect performance and there are no benchmarks proving the opposite.
The packages is essentially the same as OpenBLAS with two differences:
CONSISTENT_FPCSR=1
athttps://github.com/orkolorko/Yggdrasil/blob/697e6e7314378e42617c223bbc284780f00270ee/O/OpenBLASConsistentFPCSR/common.jl#L86