Add builder for libX11

[giordano]

It's working for all platforms, excluding x86_64 Windows. We get the following error:

imDefIc.c: In function '_XimGetInputStyle':
imDefIc.c:1342:21: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
      *input_style = (XIMStyle)p->value;
                     ^
cc1: some warnings being treated as errors

We can either ignore the error or fix it, now I'm exhausted and can't look into this.

Edit: even with make CFLAGS="-WNO-error=pointer-to-int-cast" I'm getting a ton of other errors (real errors, not something triggered by -Werror) 😕

[giordano]

These actually all these libraries:

libX11
libX11-xcb
libXau
libxcb-composite
libxcb-damage
libxcb-dpms
libxcb-dri2
libxcb-dri3
libxcb-glx
libxcb-present
libxcb-randr
libxcb-record
libxcb-render
libxcb-res
libxcb-screensaver
libxcb-shape
libxcb-shm
libxcb
libxcb-sync
libxcb-xf86dri
libxcb-xfixes
libxcb-xinerama
libxcb-xinput
libxcb-xkb
libxcb-xtest
libxcb-xvmc
libxcb-xv

I listed only the two related with x11

[giordano]

I didn't want to look into why the Makefile wasn't getting the right value, it's strange because it worked for some builds, it started failing with Linux(:aarch64, libc=:glibc)

[staticfloat]

I'm having some trouble building this locally; first the build system fails to find xtrans; I need to re-define PKG_CONFIG_PATH to ${prefix}/share/pkgconfig instead of ${prefix}/lib/pkgconfig. (I think that's correct anyway) Are you using the latest stable version of BB?

After I do that, I get the following configure error for libX11:

configure:20895: checking for poll
configure:20895: ccache /opt/i686-linux-gnu/bin/i686-linux-gnu-gcc -std=gnu99 -o conftest  -I/workspace/destdir/include  conftest.c -ldl  >&5
configure:20895: $? = 0
configure:20895: result: yes
configure:20906: checking keysym definitions
configure:20918: error: /X11 doesn't exist or isn't a directory

[giordano]

I need to re-define PKG_CONFIG_PATH to ${prefix}/share/pkgconfig instead of ${prefix}/lib/pkgconfig. (I think that's correct anyway) Are you using the latest stable version of BB?

Yes, I am. Latest BB includes this: JuliaPackaging/BinaryBuilder.jl#423

I remember getting the error about missing /X11 at some point while creating the build script, but I don't remember how it went away (maybe just updating BB? 🤔)