-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add build recipe for tempestremap library #4174
Conversation
34a2331
to
05d028a
Compare
platforms = [ | ||
Platform("x86_64", "linux"), | ||
Platform("aarch64", "linux"; libc="glibc"), | ||
Platform("x86_64", "macos"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also support Platform("aarch64", "macos")
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does NetCDF_jll
work on aarch64? if it does then yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like it? https://github.com/JuliaBinaryWrappers/NetCDF_jll.jl#platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's limited by HDF5....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no end-date to a long time I guess.... #567
05d028a
to
0710d81
Compare
Generally following the outline of the NetCDF_jll recipe made this work for linking the runtime shared lib dependencies, good to know given the prevalence of dependent NetCDF software for this project in the future. |
0710d81
to
9fa0235
Compare
libblastrampoline worked out of the box, while OpenBLAS required me to re-write the autotools blas/lapack file which is why I choose it. Given the model is going to support 1.7+ this seems a reasonable starting point which can be later relaxed. |
Dependency("HDF5_jll"), | ||
# The following is adapted from NetCDF_jll | ||
Dependency("LibCURL_jll"), | ||
# The following libraries are dependencies of LibCURL_jll which is now a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is still needed? I thought this had been fixed, but I'm not 100% sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try again locally without the libcurl deps, but adding these fixed all the issues I had.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's go with this then.
TempestRemap is a conservative, consistent and monotone remapping package for arbitrary grid geometry.
https://github.com/ClimateGlobalChange/tempestremap