Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build recipe for tempestremap library #4174

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

jakebolewski
Copy link
Contributor

TempestRemap is a conservative, consistent and monotone remapping package for arbitrary grid geometry.

https://github.com/ClimateGlobalChange/tempestremap

platforms = [
Platform("x86_64", "linux"),
Platform("aarch64", "linux"; libc="glibc"),
Platform("x86_64", "macos"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also support Platform("aarch64", "macos")?

Copy link
Contributor Author

@jakebolewski jakebolewski Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does NetCDF_jll work on aarch64? if it does then yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's limited by HDF5....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no end-date to a long time I guess.... #567

T/TempestRemap/build_tarballs.jl Outdated Show resolved Hide resolved
T/TempestRemap/build_tarballs.jl Outdated Show resolved Hide resolved
@jakebolewski
Copy link
Contributor Author

jakebolewski commented Jan 6, 2022

Generally following the outline of the NetCDF_jll recipe made this work for linking the runtime shared lib dependencies, good to know given the prevalence of dependent NetCDF software for this project in the future.

@jakebolewski
Copy link
Contributor Author

jakebolewski commented Jan 6, 2022

libblastrampoline worked out of the box, while OpenBLAS required me to re-write the autotools blas/lapack file which is why I choose it. Given the model is going to support 1.7+ this seems a reasonable starting point which can be later relaxed.

Dependency("HDF5_jll"),
# The following is adapted from NetCDF_jll
Dependency("LibCURL_jll"),
# The following libraries are dependencies of LibCURL_jll which is now a
Copy link
Member

@giordano giordano Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is still needed? I thought this had been fixed, but I'm not 100% sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try again locally without the libcurl deps, but adding these fixed all the issues I had.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's go with this then.

@giordano giordano merged commit f81c3d8 into JuliaPackaging:master Jan 6, 2022
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants