Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libgit2 to 0.28.2 #28

Merged
merged 3 commits into from
Aug 8, 2019
Merged

Bump libgit2 to 0.28.2 #28

merged 3 commits into from
Aug 8, 2019

Conversation

nalimilan
Copy link
Member

This is the companion to JuliaLang/julia#32806. I hope that's correct.

@nalimilan nalimilan changed the title Nl/libgit2 0.28 Bump libgit2 to 0.28.2 Aug 8, 2019
LibGit2/build_tarballs.jl Outdated Show resolved Hide resolved
@ararslan ararslan requested a review from staticfloat August 8, 2019 16:36
@staticfloat
Copy link
Member

lgtm

@staticfloat staticfloat merged commit a4ad617 into master Aug 8, 2019
@staticfloat staticfloat deleted the nl/libgit2-0.28 branch August 8, 2019 18:16
@staticfloat
Copy link
Member

https://github.com/JuliaPackaging/Yggdrasil/releases/tag/LibGit2-v0.28.2%2B0

@nalimilan
Copy link
Member Author

Thanks. Looks like the build scripts expect the release to be called "-1" rather than "+0"? At least that's my interpretation of the failures at https://githvub.com/JuliaLang/julia/pull/32806.

@staticfloat
Copy link
Member

Yes, we are transitioning from a vX.Y.Z-BUILD format to vX.Y.Z+BUILD format, as it makes version comparisons simpler. (We don't actually do any version comparisons yet, but someday we will).

You need to change this line: https://github.com/JuliaLang/julia/pull/32806/files#diff-a01ad0cac7aa5a648c5d00ec39bd9afcR100

Instead of LibGit2-v$(LIBGIT2_VER)-$(LIBGIT2_BB_REL) at the end, change it to LibGit2-v$(LIBGIT2_VER)+$(LIBGIT2_BB_REL). Then also change LIBGIT2_BB_REL to 0 instead of 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants