Disallow binaries by default on non-glibc Linux #333
Conversation
|
There should really be a way of detecting or annotating an actual minimum here for any given binary. |
|
That would be neat but that sounds like a pretty significant change, since you'd also have to inspect all downloaded binaries and reliably determine the glibc version they require. Worth thinking about, though that's more than I wanted to get into with this PR. |
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
=======================================
Coverage 38.61% 38.61%
=======================================
Files 4 4
Lines 839 839
=======================================
Hits 324 324
Misses 515 515
Continue to review full report at Codecov.
|
| elseif Compat.Sys.islinux() || (Compat.Sys.isbsd() && !Compat.Sys.isapple()) | ||
| defaults = [PackageManager,SystemPaths,Binaries,BuildProcess] | ||
| defaults = if Compat.Sys.isbsd() | ||
| [Binaries, PackageManager, SystemPaths, BuildProcess] |
There was a problem hiding this comment.
I don't think Binaries are safe to enable for non-Apple bsd here.
Replaces #327