Change the Implimentation of CSRMatrix to us SparseMatrixCSC #101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 88.25% 88.29% +0.03%
==========================================
Files 12 12
Lines 1337 1341 +4
==========================================
+ Hits 1180 1184 +4
Misses 157 157
Continue to review full report at Codecov.
|
|
So there is a great improvement on Clp, right? Have you benchmarked any other solvers? |
|
This change it's self isn't really responsible for much performance improvement, it is more of a move towards base julia functionality. But it does result in on due to SparseMatrixCSC haveing many performance optimizations. The benchmarks for this change were neutral because it effectively is just code simplification. I do have the changes ready for Gurobi.jl, and GLPK.jl. Both of which are literally a few characters. I was just waiting for this to get merged before submitting them. |
|
Are there any blocking issues or concerns from the reviewers? |
|
If there are no regressions on gurobi I am ok with merging. |
|
@joaquimg I don't have access to gurobi, but GLPK is similar in use and the benchmarks in jump-dev/GLPK.jl#95 show no change in performance. |
|
Then its good to go IMO. |
|
Can we rebase this on the latest master please? Then it's good to merge. |
…l value at the end of row_pointers that signifies the end of that row
Remove Depreciation add sparse conversion
Small Fix
Change CSRMatrix to Adjoint{Sparse}}
Cleanup
Cleanup comments
Comment cleanup
cleanup
Changed Adjoint to Transpose
Rebase to no CI for julia v 0.6 (#1)
* Update appveyor.yml
remove testing for v0.6 add v1.1
* Update .travis.yml
drop testing for v0.6 add v1.1
* change require to julia 0.7
* This changes the implementation of CSRMatrix to include the additional value at the end of row_pointers that signifies the end of that row
* Remove Depreciation add sparse conversion
* Small Fix
* Change CSRMatrix to Adjoint{Sparse}}
* Cleanup
* Cleanup comments
* Comment cleanup
* cleanup
* Changed Adjoint to Transpose
Remove commented lines
Fix Collect statement
drop v0.7
|
I think that we are good to go. |
This is a continuation of #96. Which got accidentally closed.
The gist of this is that it changes CSRMatrix to be an alias for Transpose{SparseMatrixCSC}