Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use namedtuple for default options. #1026

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Use namedtuple for default options. #1026

merged 1 commit into from
Jan 24, 2023

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Jan 24, 2023

Fixes #1021

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #1026 (de45d21) into master (7fa215a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1026      +/-   ##
==========================================
+ Coverage   85.25%   85.30%   +0.05%     
==========================================
  Files          42       43       +1     
  Lines        3194     3199       +5     
==========================================
+ Hits         2723     2729       +6     
+ Misses        471      470       -1     
Impacted Files Coverage Δ
src/multivariate/optimize/interface.jl 82.07% <100.00%> (+0.94%) ⬆️
...tivariate/solvers/constrained/ipnewton/ipnewton.jl 96.64% <100.00%> (ø)
...olvers/first_order/accelerated_gradient_descent.jl 100.00% <100.00%> (ø)
...e/solvers/first_order/momentum_gradient_descent.jl 100.00% <100.00%> (ø)
src/multivariate/solvers/first_order/ngmres.jl 94.90% <100.00%> (ø)
src/utilities/generic.jl 100.00% <0.00%> (ø)
src/Optim.jl 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pkofod pkofod merged commit 1f1258c into master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rosenbrock example: Type instability
1 participant