Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodiff support for 2nd order constraints #116

Merged
merged 12 commits into from
May 26, 2020
Merged

Autodiff support for 2nd order constraints #116

merged 12 commits into from
May 26, 2020

Conversation

longemen3000
Copy link
Contributor

@longemen3000 longemen3000 commented Jan 25, 2020

added calculation of jacobians and hessians of constraints with just the base definition (it is recommendable to provide a hand coded jacobian, as jacobians can be relatively easier to write than the hessians and speed up the differenciation considerably). with the two available autodiff modes (FiniteDiff and ForwardDiff). also updated autodiffed OnceDifferenciableConstraints to uses the appropiate fdtype

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #116 into master will increase coverage by 1.23%.
The diff coverage is 99.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   93.96%   95.19%   +1.23%     
==========================================
  Files          10       10              
  Lines         497      583      +86     
==========================================
+ Hits          467      555      +88     
+ Misses         30       28       -2
Impacted Files Coverage Δ
src/objective_types/constraints.jl 98.5% <99.03%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8f0c2...c55363f. Read the comment docs.

@longemen3000 longemen3000 changed the title ForwardDiff support for 2nd order constraints Autodiff support for 2nd order constraints Jan 27, 2020
@pkofod
Copy link
Member

pkofod commented May 26, 2020

I'm sorry this took forever. Looks great, thanks.

@pkofod pkofod merged commit 1e5d175 into JuliaNLSolvers:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants