Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing Ecut as a keyword argument #489

Merged
merged 7 commits into from
Jul 17, 2021
Merged

Allow passing Ecut as a keyword argument #489

merged 7 commits into from
Jul 17, 2021

Conversation

mfherbst
Copy link
Member

Also makes the compiler emit a deprecation warning (if explicitly turned on) about the old interface being deprecated now.

@antoine-levitt
Copy link
Member

Ah you beat me to it, I was just doing this now

@antoine-levitt
Copy link
Member

I had a

## Note the implicit passing of keyword arguments here:
## this is equivalent to PlaneWaveBasis(model; Ecut=Ecut, kgrid=kgrid)

in tutorial.md because that might be confusing to new julia users

@mfherbst
Copy link
Member Author

Sorry ... I thought it was clear in the comment I left that I would do it.

@mfherbst
Copy link
Member Author

good point

@antoine-levitt
Copy link
Member

There's a bunch of other places we could replace the pattern X=X (or X = X) by X, but it has been too long since I used regexpes

@mfherbst
Copy link
Member Author

Yeah, I know, but I suggest we just fix it when we find it.

@antoine-levitt
Copy link
Member

Yup, just might have been a good candidate while we were search&replacing stuff

@mfherbst mfherbst enabled auto-merge (squash) July 17, 2021 17:49
@mfherbst mfherbst merged commit 17c1d5f into master Jul 17, 2021
@mfherbst mfherbst deleted the EcutKwarg branch July 17, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants