Ω+K, split version #477
Merged
Ω+K, split version #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfherbst
reviewed
Jul 9, 2021
| @@ -169,7 +169,8 @@ end | |||
| # With χ04P = -Ω^-1, | |||
| # (Ω+K)^-1 = Ω^-1 (1 - K(1+Ω^-1 K)^-1 Ω^-1) | |||
| # (Ω+K)^-1 = -χ04P (1 + K(1 - χ04P K)^-1 χ04P) | |||
| # (Ω+K)^-1 = -χ04P (1 + K(1 - χ0 K)^-1 χ04P) | |||
| # (Ω+K)^-1 = -χ04P (1 + E K2P (1 - χ02P K2P)^-1 R χ04P) | |||
| # where χ02P = R χ04P E and K2P = R K E | |||
There was a problem hiding this comment.
Ok, but this opens up the question what is R and E ... I feel we should document a few of these things at a central place and then just take it as granted knowledge
Talking about a hackaton, that's the sort of annoying tasks one could leave for that.
There was a problem hiding this comment.
It is on top of the file. Agree the documentation is not great right now, I want to wait until things settle down to overhaul it
There was a problem hiding this comment.
Also not sure how to communicate this best. E and R are nice but a bit on the formal side. The code is actually simpler than the formulas here.
There was a problem hiding this comment.
Yeah, I agree. Not always easy to find a good balance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.