Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :diagonal option to test_approx_equal #73

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Add :diagonal option to test_approx_equal #73

merged 4 commits into from
Jun 5, 2023

Commits on Jun 3, 2023

  1. Update AtomsBaseTesting.jl 

    Added option `:diagonal` to AtomsBaseTesting `test_approx_equal`. The current options are not compatible with Molly.jl (triclinic & DirichletZero) and I would like to test against a valid system.

Also is `DirhichletZero` supposed to be a hard wall or infinite domain or something else?  Doesn't really make a difference for Molly but its not really clear from docs and not something I've ever seen in a molecular simulation context.
    @ejmeitz
    ejmeitz authored Jun 3, 2023
    Configuration menu
    Copy the full SHA
    bc21b3e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Update runtests.jl 

    Add :diagonal to tests
    @ejmeitz
    ejmeitz authored Jun 4, 2023
    Configuration menu
    Copy the full SHA
    6680f69 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from ejmeitz/patch-2 

    Update runtests.jl
    @ejmeitz
    ejmeitz authored Jun 4, 2023
    Configuration menu
    Copy the full SHA
    8097a58 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. fix tests

    @ejmeitz
    ejmeitz committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    bda7558 View commit details
    Browse the repository at this point in the history