Include some special casing for chemical species #126
+65
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few more special cases to the handling of chemical species plus a bit of cleanup.
:X
is fairly common in atomic structure files as a "dummy atom" with atomic number0
. We can either force everyone to drop such atoms before using our stuff or include support here.Here I am proposing to add this special case along with
:T
for tritium.Note that I'm changing the Z -> data cache from an array to a Dict. Not sure if that has big performance implications, one could also handle this differently. @cortner probably knows if this may be an issue.