Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ngcd (redux) #332

Merged
merged 49 commits into from
Apr 7, 2021
Merged

Clean up ngcd (redux) #332

merged 49 commits into from
Apr 7, 2021

Conversation

jverzani
Copy link
Member

@jverzani jverzani commented Apr 2, 2021

Further clean up of ngcd.jl code:

  • move NCPolynomial out of module, rename ΠₙPolynomial, a name likely to change
  • refactor some of ngcd code.

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #332 (d3b5ddd) into master (f3c55c1) will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   90.77%   91.52%   +0.75%     
==========================================
  Files          15       16       +1     
  Lines        1972     1959      -13     
==========================================
+ Hits         1790     1793       +3     
+ Misses        182      166      -16     
Impacted Files Coverage Δ
src/polynomials/ngcd.jl 96.25% <100.00%> (+5.98%) ⬆️
src/polynomials/pi_n_polynomial.jl 100.00% <100.00%> (ø)
src/common.jl 90.40% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3c55c1...d3b5ddd. Read the comment docs.

@jverzani jverzani merged commit f0ed210 into JuliaMath:master Apr 7, 2021
@jverzani jverzani deleted the pi_n branch April 7, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant