Skip to content

Commit

Permalink
Issue ngcd (#318)
Browse files Browse the repository at this point in the history
* fix issue with ngcd

* version bump
  • Loading branch information
jverzani authored Mar 23, 2021
1 parent 3ceb43c commit 815ab1a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name = "Polynomials"
uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
license = "MIT"
author = "JuliaMath"
version = "2.0.0"
version = "2.0.1"

[deps]
Intervals = "d8418881-c3e1-53bb-8760-2df7ec849ed5"
Expand Down
8 changes: 4 additions & 4 deletions src/polynomials/ngcd.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ In the case `degree(p) ≫ degree(q)`, a heuristic is employed to first call on
function ngcd(p::P, q::Q, args...;kwargs...) where {T, S, P<:StandardBasisPolynomial{T}, Q <: StandardBasisPolynomial{S}}

degree(p) < 0 && return (u=q, v=p, w=one(q), θ=NaN, κ=NaN)
degree(p) == 0 && return (u=one(q), v=p, w=zero(q), θ=NaN, κ=NaN)
degree(p) == 0 && return (u=one(q), v=p, w=q, θ=NaN, κ=NaN)
degree(q) < 0 && return (u=one(q), v=p, w=zero(q), θ=NaN, κ=NaN)
degree(q) == 0 && return (u=one(p), v=p, w=q, θ=NaN, κ=NaN)
assert_same_variable(p,q)
assert_same_variable(p,q)

p′,q′ = promote(p,q)

Expand Down Expand Up @@ -264,8 +264,8 @@ end
# return guess at smallest singular value and right sinuglar value, x
# for an upper triangular matrix, V
function smallest_singular_value(V::AbstractArray{T,2},
atol=eps(T),
rtol=zero(T)) where {T}
atol=eps(real(T)),
rtol=zero(real(T))) where {T}

R = UpperTriangular(V)
k = size(R)[1]/2
Expand Down

2 comments on commit 815ab1a

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/32649

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.0.1 -m "<description of version>" 815ab1acbaffb7fcc0261730311d7cf13913084c
git push origin v2.0.1

Please sign in to comment.