Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeasureBase 0.14 + other updates #260

Closed
wants to merge 9 commits into from
Closed

MeasureBase 0.14 + other updates #260

wants to merge 9 commits into from

Conversation

cscherrer
Copy link
Collaborator

@cscherrer cscherrer commented Aug 21, 2023

This is a quick fix to get MeasureTheory working with the latest MeasureBase (currently v0.14). Note that some tests have been removed; these will be reworked and added to MeasureBase.jl.

Addresses #259

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer cscherrer marked this pull request as ready for review August 21, 2023 18:38
@cscherrer cscherrer linked an issue Aug 21, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.89% ⚠️

Comparison is base (198ee9f) 45.98% compared to head (07074d6) 45.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   45.98%   45.09%   -0.89%     
==========================================
  Files          43       43              
  Lines        1344     1346       +2     
==========================================
- Hits          618      607      -11     
- Misses        726      739      +13     
Files Changed Coverage Δ
src/distributions.jl 0.00% <ø> (ø)
src/parameterized/gamma.jl 0.00% <0.00%> (ø)
src/parameterized/inverse-gaussian.jl 0.00% <0.00%> (ø)
src/parameterized/snedecorf.jl 0.00% <0.00%> (ø)
src/transforms/corrcholeskylower.jl 0.00% <0.00%> (ø)
src/transforms/ordered.jl 0.00% <0.00%> (ø)
src/parameterized/normal.jl 47.61% <33.33%> (ø)
src/parameterized/lkj-cholesky.jl 66.66% <50.00%> (-8.34%) ⬇️
src/transforms/corrcholesky.jl 53.84% <50.00%> (-23.08%) ⬇️
src/parameterized/cauchy.jl 64.70% <66.66%> (+4.70%) ⬆️
... and 13 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cscherrer cscherrer requested a review from mschauer August 21, 2023 18:43
@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer
Copy link
Collaborator Author

@gaurav-arya Since you brought this up, I've invited you to the repo in case you'd like to review. @mschauer I've also requested a review if you're available in case you have thoughts on this. It's a small PR so hopefully quick to review :)

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

Copy link
Collaborator

@gaurav-arya gaurav-arya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good frrom a rough scan, just left a few questions

src/transforms/corrcholesky.jl Show resolved Hide resolved
src/distributions.jl Show resolved Hide resolved
src/MeasureTheory.jl Show resolved Hide resolved
@cscherrer
Copy link
Collaborator Author

Thanks @gaurav-arya . I've merged this branch into #240, which has some other changes we had planned. Once we're set here we can close this PR and merge that one instead.

@cscherrer cscherrer closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Static.jl compat
2 participants