Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support under Julia v1.6 #15

Closed
wants to merge 1 commit into from

Conversation

hyrodium
Copy link
Contributor

Julia v1.6 is the new LTS, and v1.0 is no longer maintained. This PR replaces v1.0 with v1.6.

@coveralls
Copy link

coveralls commented Apr 24, 2022

Pull Request Test Coverage Report for Build 2215647081

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1333249280: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@devmotion
Copy link
Member

There is no need to drop support just because a new LTS was released. Many packages still support older Julia versions. IMO dropping of Julia < 1.6 should only be done if it blocks development or increases code complexity and/or maintenance burden unreasonable. I don't think this is the case here, hence I'll close this PR.

@devmotion devmotion closed this Apr 24, 2022
@hyrodium
Copy link
Contributor Author

IMO dropping of Julia < 1.6 should only be done if it blocks development or increases code complexity and/or maintenance burden unreasonable.

I opened this PR because of this test failure on #14 : https://github.com/JuliaMath/IrrationalConstants.jl/runs/6146750074?check_suite_focus=true

I think we need to add testing on Julia v1.6 in any cases.

@devmotion
Copy link
Member

I think we need to add testing on Julia v1.6 in any cases.

Yes, that we should definitely do. IMO we should test at least the oldest supported version, LTS, and the current stable version.

@hyrodium
Copy link
Contributor Author

Yes, that we should definitely do.

Should we reopen this PR, or should I make a new PR?

@devmotion
Copy link
Member

I think a separate PR is cleaner, I opened #16.

@hyrodium
Copy link
Contributor Author

@JeffreySarnoff Could you reopen this PR? I'll resolve the conflicts. (x-ref #14 (comment))

@devmotion
Copy link
Member

I still don't see why we would want to do this - the package works just fine with Julia 1.0. As said above, currently I don't think there's any reason to drop support for Julia 1.0 as there are no issues from our side and there is no specific maintenance needed for Julia 1.0.

@JeffreySarnoff
Copy link
Member

@hyrodium given ^, no need ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants