-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support under Julia v1.6 #15
Conversation
Pull Request Test Coverage Report for Build 2215647081Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There is no need to drop support just because a new LTS was released. Many packages still support older Julia versions. IMO dropping of Julia < 1.6 should only be done if it blocks development or increases code complexity and/or maintenance burden unreasonable. I don't think this is the case here, hence I'll close this PR. |
I opened this PR because of this test failure on #14 : https://github.com/JuliaMath/IrrationalConstants.jl/runs/6146750074?check_suite_focus=true I think we need to add testing on Julia |
Yes, that we should definitely do. IMO we should test at least the oldest supported version, LTS, and the current stable version. |
Should we reopen this PR, or should I make a new PR? |
I think a separate PR is cleaner, I opened #16. |
@JeffreySarnoff Could you reopen this PR? I'll resolve the conflicts. (x-ref #14 (comment)) |
I still don't see why we would want to do this - the package works just fine with Julia 1.0. As said above, currently I don't think there's any reason to drop support for Julia 1.0 as there are no issues from our side and there is no specific maintenance needed for Julia 1.0. |
@hyrodium given ^, no need .. |
Julia v1.6 is the new LTS, and v1.0 is no longer maintained. This PR replaces
v1.0
withv1.6
.