Change fallback unsafe_gamma for x::Real to x<:AbstractFloat. Add (#28)

* Change fallback unsafe_gamma for x::Real to x<:AbstractFloat. Add fallback for generic argument to default gamma function. * Remove unnecessary float conversion. * Final cleanup to unsafe_gamma. Bump version. * Remove commented line. Sorry for hasty push earlier. Co-authored-by: Chris Geoga <{ID}+{username}@users.noreply.github.com>
JuliaMath · Aug 9, 2020 · f4461b4 · f4461b4 · MikaelSlevinsky · Aug 9, 2020
1 parent 720e95d
commit f4461b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "HypergeometricFunctions"
 uuid = "34004b35-14d8-5ef3-9330-4cdb6864b03a"
-version = "0.3.1"
+version = "0.3.2"
 
 [deps]
 DualNumbers = "fa6b7ba4-c1ee-5f82-b5fc-ecf0adba8f74"

diff --git a/src/specialfunctions.jl b/src/specialfunctions.jl
@@ -141,15 +141,13 @@ const libm = Base.libm_name
 
 unsafe_gamma(x::Float64) = ccall((:tgamma, libm),  Float64, (Float64, ), x)
 unsafe_gamma(x::Float32) = ccall((:tgammaf, libm),  Float32, (Float32, ), x)
-unsafe_gamma(x::Real) = unsafe_gamma(float(x))
 function unsafe_gamma(x::BigFloat)
     z = BigFloat()
     ccall((:mpfr_gamma, :libmpfr), Int32, (Ref{BigFloat}, Ref{BigFloat}, Int32), z, x, Base.MPFR.ROUNDING_MODE[])
     return z
 end
-unsafe_gamma(z::Complex) = gamma(z)
 unsafe_gamma(z::Dual) = (r = realpart(z);w = unsafe_gamma(r); dual(w, w*digamma(r)*dualpart(z)))
-
+unsafe_gamma(z) = gamma(z) 
 """
     @lanczosratio(z, ϵ, c₀, c...)