Skip to content

Commit

Permalink
refactor: prefix extensions with package name
Browse files Browse the repository at this point in the history
- this will ensure extension names are unique
- whenever there is another package with same ext name, building sysimage fails
- ex: LogExpFunctions has its own ChainRulesCoreExt.jl
  • Loading branch information
ven-k committed Feb 9, 2023
1 parent 856eb37 commit f86ce6a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

[extensions]
ChainRulesCoreExt = "ChainRulesCore"
ChainOfVariablesChainRulesCoreExt = "ChainRulesCore"

[compat]
ChainRulesCore = "1"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module ChainRulesCoreExt
module ChainOfVariablesChainRulesCoreExt

using ChainRulesCore

Expand Down
2 changes: 1 addition & 1 deletion src/ChangesOfVariables.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ using Test
include("with_ladj.jl")
include("test.jl")
if !isdefined(Base, :get_extension)
include("../ext/ChainRulesCoreExt.jl")
include("../ext/ChainOfVariablesChainRulesCoreExt.jl")
end

end # module

0 comments on commit f86ce6a

Please sign in to comment.