Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sectional curvature #711

Merged
merged 15 commits into from
Mar 23, 2024
Merged

Sectional curvature #711

merged 15 commits into from
Mar 23, 2024

Conversation

mateuszbaran
Copy link
Member

Just finishing the work on sectional curvature.

@mateuszbaran mateuszbaran added the preview docs Add this label if you want to see a PR-preview of the documentation label Mar 16, 2024
src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
src/utils.jl Outdated Show resolved Hide resolved
@kellertuer
Copy link
Member

Hm, direct dependency is not so nice, but maybe necessary here to finish this in finite time. Really a bit sad that BVP breaks so often

@mateuszbaran
Copy link
Member Author

Yes, I don't like this solution but I hope this is only a temporary measure until they fix the bug. It seems that BVP breaks more often than all our other dependencies combined...

@mateuszbaran
Copy link
Member Author

Speaking of bugs in other dependencies...

ERROR: LoadError: UndefVarError: `pyisnone` not defined
Stacktrace:
  [1] getproperty
    @ ./Base.jl:31 [inlined]
  [2] _py_bbox(obj::PythonCall.Core.Py)
    @ Plots ~/.julia/packages/Plots/a3u1v/src/backends/pythonplot.jl:219
  [3] _update_min_padding!(sp::Plots.Subplot{Plots.PythonPlotBackend})
    @ Plots ~/.julia/packages/Plots/a3u1v/src/backends/pythonplot.jl:1253

@mateuszbaran
Copy link
Member Author

See JuliaPlots/Plots.jl#4905 (the name of user opening that issue 😄)

@mateuszbaran
Copy link
Member Author

It looks like with two new constraints, CI is passing. I'd suggest merging #710 and #712 first, and this one last, and then release 0.9.15 @kellertuer .

I've also updated the default vector transport method as discussed there: JuliaManifolds/Manopt.jl#349 (comment) .

@kellertuer
Copy link
Member

Nice, sounds like a good plan to me :)

@mateuszbaran
Copy link
Member Author

Great, then I'll go with it.

@mateuszbaran mateuszbaran merged commit a48789c into master Mar 23, 2024
24 checks passed
@kellertuer kellertuer deleted the mbaran/sectional-curvature branch May 4, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview docs Add this label if you want to see a PR-preview of the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants