broadcasting for UMVTVector

[mateuszbaran]

No description provided.

[codecov]

Codecov Report

Merging #339 (5027f12) into master (2cfc9ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          76       76           
  Lines        5870     5888   +18     
=======================================
+ Hits         5731     5749   +18     
  Misses        139      139           

Impacted Files	Coverage Δ
src/manifolds/FixedRankMatrices.jl	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cfc9ec...5027f12. Read the comment docs.

[mateuszbaran]

@sethaxen The failure on Julia nightly seems to be related to matrix logarithm:

[ Info: Testing rotations.jl
rotation vector [0.0, 0.0, 3.141592653589793, 0.0, 0.0, 3.141592653589793]: Error During Test at D:\a\Manifolds.jl\Manifolds.jl\test\rotations.jl:142
  Got exception outside of a @test
  LAPACKException(1)
  Stacktrace:
    [1] chklapackerror(ret::Int64)
      @ LinearAlgebra.LAPACK C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\lapack.jl:38
    [2] trsyl!(transa::Char, transb::Char, A::SubArray{Float64, 2, Matrix{Float64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, B::SubArray{Float64, 2, Matrix{Float64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, C::SubArray{Float64, 2, Matrix{Float64}, Tuple{UnitRange{Int64}, UnitRange{Int64}}, false}, isgn::Int64)
      @ LinearAlgebra.LAPACK C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\lapack.jl:6469
    [3] trsyl!
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\lapack.jl:6450 [inlined]
    [4] _sylvester_2x2!
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\dense.jl:1563 [inlined]
    [5] _sqrt_quasitriu_offdiag_block_2x2!
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\triangular.jl:2525 [inlined]
    [6] _sqrt_quasitriu_offdiag_block!(R::Matrix{Float64}, A::Matrix{Float64})
      @ LinearAlgebra C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\triangular.jl:2419
    [7] _sqrt_quasitriu!
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\triangular.jl:2385 [inlined]
    [8] _find_params_log_quasitriu!(A::Matrix{Float64})
      @ LinearAlgebra C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\triangular.jl:1905
    [9] _log_quasitriu!(A0::Matrix{Float64}, A::Matrix{Float64})
      @ LinearAlgebra C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\triangular.jl:1828
   [10] log_quasitriu(A0::Matrix{Float64})
      @ LinearAlgebra C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\triangular.jl:1813
   [11] log(A::Matrix{Float64})
      @ LinearAlgebra C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\LinearAlgebra\src\dense.jl:728
   [12] log_safe
      @ D:\a\Manifolds.jl\Manifolds.jl\src\utils.jl:65 [inlined]
   [13] log!(M::Rotations{4}, X::Matrix{Float64}, p::Matrix{Float64}, q::Matrix{Float64})
      @ Manifolds D:\a\Manifolds.jl\Manifolds.jl\src\manifolds\Rotations.jl:515
   [14] log(M::Rotations{4}, p::Matrix{Float64}, q::Matrix{Float64})
      @ ManifoldsBase ~\.julia\packages\ManifoldsBase\E0gzS\src\ManifoldsBase.jl:581
   [15] macro expansion
      @ D:\a\Manifolds.jl\Manifolds.jl\test\rotations.jl:148 [inlined]
   [16] macro expansion
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\Test\src\Test.jl:1153 [inlined]
   [17] macro expansion
      @ D:\a\Manifolds.jl\Manifolds.jl\test\rotations.jl:143 [inlined]
   [18] macro expansion
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\Test\src\Test.jl:1153 [inlined]
   [19] macro expansion
      @ D:\a\Manifolds.jl\Manifolds.jl\test\rotations.jl:129 [inlined]
   [20] macro expansion
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\Test\src\Test.jl:1153 [inlined]
   [21] macro expansion
      @ D:\a\Manifolds.jl\Manifolds.jl\test\rotations.jl:92 [inlined]
   [22] macro expansion
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\Test\src\Test.jl:1153 [inlined]
   [23] top-level scope
      @ D:\a\Manifolds.jl\Manifolds.jl\test\rotations.jl:4
   [24] include
      @ .\client.jl:451 [inlined]
   [25] macro expansion
      @ .\timing.jl:210 [inlined]
   [26] include_test(path::String)
      @ Main D:\a\Manifolds.jl\Manifolds.jl\test\utils.jl:27
   [27] macro expansion
      @ D:\a\Manifolds.jl\Manifolds.jl\test\runtests.jl:126 [inlined]
   [28] macro expansion
      @ C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.7\Test\src\Test.jl:1153 [inlined]
   [29] top-level scope
      @ D:\a\Manifolds.jl\Manifolds.jl\test\runtests.jl:9
   [30] include(fname::String)
      @ Base.MainInclude .\client.jl:451
   [31] top-level scope
      @ none:6
   [32] eval
      @ .\boot.jl:369 [inlined]
   [33] exec_options(opts::Base.JLOptions)
      @ Base .\client.jl:268
   [34] _start()
      @ Base .\client.jl:495

Could that be related to JuliaLang/julia#39973 ?

[sethaxen]

Yeah, it's probably an edge case I didn't handle for that PR. Will look into it.

[sethaxen]

It is indeed an issue with the new real sqrt. Opened an issue here: JuliaLang/julia#40141

[mateuszbaran]

Thanks for looking into it 👍 .