Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type stabilization of ProductArray #247

Merged
merged 4 commits into from
Nov 11, 2020

Conversation

mateuszbaran
Copy link
Member

This should really fix #246.

@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #247 (060e01c) into master (71cc388) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   95.56%   95.60%   +0.03%     
==========================================
  Files          70       70              
  Lines        4443     4436       -7     
==========================================
- Hits         4246     4241       -5     
+ Misses        197      195       -2     
Impacted Files Coverage Δ
src/manifolds/VectorBundle.jl 98.19% <100.00%> (-0.01%) ⬇️
src/product_representations.jl 88.88% <100.00%> (+5.55%) ⬆️
src/groups/product_group.jl 94.59% <0.00%> (-2.85%) ⬇️
src/groups/group.jl 76.43% <0.00%> (-0.53%) ⬇️
src/manifolds/ProductManifold.jl 89.56% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71cc388...060e01c. Read the comment docs.

@mateuszbaran
Copy link
Member Author

@sethaxen does this fix your problem? Can I merge this?

Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this works for me now. Thanks for the fix! Can you bump the patch version number for a release?

@mateuszbaran
Copy link
Member Author

Sure, I'll bump and tag.

@mateuszbaran mateuszbaran merged commit 29b1b01 into master Nov 11, 2020
@kellertuer kellertuer deleted the mbaran/type-stable-productarray branch August 2, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allocate_result type-unstable for ProductArray
2 participants