Add missing fields to Parameter
#29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were missing the fields `nu` and `regularize_bias` in the `Parameter` structure. Fixes JuliaML#28. Discovered when working on JuliaML/LIBSVM.jl/#98.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request successfully adds the missing fields 'nu' and 'regularize_bias' to the 'Parameter' structure, which were identified as necessary for the project. This enhancement is in line with the reported issue and the related work in the LIBSVM.jl repository.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the addition of new fields is accompanied by updates to any associated documentation or examples where the 'Parameter' structure is used.
- Consider whether any existing unit tests need to be updated or if new tests should be added to cover the changes made to the 'Parameter' structure.
- Review the initialization and usage of the new fields across the codebase to maintain consistency and prevent any potential issues with default values or missing assignments.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the fields
nuandregularize_biasin theParameterstructure.Fixes #28.
Discovered when working on JuliaML/LIBSVM.jl#98.