Fix and simplify CI setup #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the documentation setup introduced in PR 94 was that the actions were improperly specified. That is fixed in this commit. In addition, the following changes were made to simplify the setup, bringing it more in line with Example.jl (I actually copied the file from there and made individual changes) and most other Julia packages: - The cronjob for running tests has been removed; it doesn't provide meaningful benefit atop running on PRs, tags, and pushes to `main`. - The concurrency specification has been removed. I believe what's specified is actually the default behavior. - `include` mentions a version check and branch protection but neither are present (I assume this was copied from elsewhere) so that step has been removed. - The separate `JuliaNightly` CI has been incorporated back into the regular CI setup as an `include` step. This avoids duplication. - <https://github.com/JuliaRegistries/TagBot> provides a template in its README which includes a few more items not present in the one here. Those have been added. Hopefully these changes will make things more consistent and easier to maintain going forward.
|
Nice, CI is running! 🙂 |
Codecov ReportBase: 85.52% // Head: 87.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 85.52% 87.63% +2.11%
==========================================
Files 8 9 +1
Lines 1181 1343 +162
==========================================
+ Hits 1010 1177 +167
+ Misses 171 166 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thank you very much for your help! I'll correct the error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the documentation setup introduced in #94 was that the actions were improperly specified. That is fixed in this commit.
In addition, the following changes were made to simplify the setup, bringing it more in line with Example.jl (I actually copied the file from there and made individual changes) and most other Julia packages:
main.includementions a version check and branch protection but neither are present (I assume this was copied from elsewhere) so that step has been removed.JuliaNightlyCI has been incorporated back into the regular CI setup as anincludestep. This avoids duplication.Hopefully these changes will make things more consistent and easier to maintain going forward.