Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuse broadcast calls #88

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fuse broadcast calls #88

merged 1 commit into from
Aug 23, 2022

Conversation

stevengj
Copy link
Member

An expression like -conj.(v) generates an extra temporary array (since conj.(v) allocates an array, then -vector allocates another array. If you instead do .-conj.(v), then Julia will "fuse" the two broadcast operations into a single loop, producing a single array.

Read More Dots: Syntactic Loop Fusion in Julia.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #88 (31064b0) into main (614c38a) will increase coverage by 0.83%.
The diff coverage is 91.20%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   81.14%   81.98%   +0.83%     
==========================================
  Files           9        9              
  Lines        1236     1238       +2     
==========================================
+ Hits         1003     1015      +12     
+ Misses        233      223      -10     
Impacted Files Coverage Δ
src/tridiag.jl 75.18% <77.14%> (ø)
src/cholesky.jl 95.16% <100.00%> (ø)
src/jmatrix.jl 95.65% <100.00%> (+15.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smataigne smataigne merged commit 534b987 into main Aug 23, 2022
@stevengj stevengj deleted the stevengj-patch-2 branch August 23, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants