Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI tests #4

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Fix CI tests #4

merged 3 commits into from
Aug 5, 2022

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Aug 5, 2022

This should fix the failing CI tests — the problem is that, depending on how matrix-multiplication is implemented, A*A may not be exactly Hermitian for a skew-Hermitian A (due to roundoff errors, if different parts of the matrix are computed differently).

@smataigne
Copy link
Collaborator

This should fix the failing CI tests — the problem is that, depending on how matrix-multiplication is implemented, A*A may not be exactly Hermitian for a skew-Hermitian A (due to roundoff errors, if different parts of the matrix are computed differently).

Thank you very much for the different updates, I will look at the Schur decomposition. I've already done Cholesky-like but some permutation problems must still be fixed.

@smataigne smataigne merged commit d286ad4 into JuliaLinearAlgebra:main Aug 5, 2022
@stevengj stevengj deleted the codereview2 branch August 5, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants