Smataigne #19
Merged
Smataigne #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Aug 9, 2022
| ``` | ||
| """ | ||
| function SkewHermTridiagonal(A::AbstractMatrix) | ||
| if diag(A, 1) == - adjoint.(diag(A, -1)) |
There was a problem hiding this comment.
This allocates 4 arrays and then discards them; not sure if we care, but it's a bit excessive for a check.
You can remove 1 allocation by saving ev = diag(A,1) (since you re-use it on the same line), and another allocation by using .- instead of - (since .- will "fuse" with the adjoint.(...) call).
|
If you add "closes #17" to the PR description, then that issue would automatically be closed when this is merged. |
|
Also I would recommend having a more descriptive commit/PR title than "Smataigne" … imagine that you are reading the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tridiag.jl added to package