Givens of zero vector and non strict stopping criterion #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#113 solved |
Codecov ReportBase: 88.81% // Head: 88.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 88.81% 88.82%
=======================================
Files 9 9
Lines 1422 1423 +1
=======================================
+ Hits 1263 1264 +1
Misses 159 159
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Sorry, I am still missing the test cases, which prove #113 is solved. Could not verify that in my copy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Givens of a zero vector created NaN values and the strict stopping criterion was never true for exact zeroes.