Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Tuple{Vararg{LinearMap}} notation #132

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Adjust Tuple{Vararg{LinearMap}} notation #132

merged 1 commit into from
Jan 19, 2021

Conversation

dkarrasch
Copy link
Member

If I understand correctly, this is how it's supposed to be written after JuliaLang/julia#38136 (whose exact consequences I don't understand), and I was indeed seeing warnings during the tests on my local nightly (though not in the CI runs):

WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).
WARNING: Wrapping `Vararg` directly in UnionAll is deprecated (wrap the tuple instead).

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #132 (9250d09) into master (809ab02) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          14       14           
  Lines         906      906           
=======================================
  Hits          901      901           
  Misses          5        5           
Impacted Files Coverage Δ
src/composition.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809ab02...9250d09. Read the comment docs.

@dkarrasch dkarrasch merged commit 66cc03e into master Jan 19, 2021
@dkarrasch dkarrasch deleted the dk/vararg branch January 19, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant