Fix bounds checking for certain sparse matrix cases #9864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @simd for k in colptrA[col]:colptrA[col+1]-1 | ||
| if rowvalA[k] in I; nnzS += 1 end # `in` is fast for ranges | ||
| @inbounds nnzS += rowvalA[k] in I # `in` is fast for ranges |
There was a problem hiding this comment.
This had @simd but not @inbounds, so it wasn't vectorizable. I haven't checked to see if LLVM is actually vectorizing it now, but it's conceivably possible.
simonster
force-pushed
the
sjk/sparse-bounds
branch
from
1f4ef93 to
db7cb12
Compare
simonster
added a commit
that referenced
this pull request
Jan 22, 2015
Fix bounds checking for certain sparse matrix cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this did not throw for
spmat[0:1, 1]and some related cases, and threw "invalid Array dimensions" forspmat[:, 0:1]instead of a BoundsError.