Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NTFS junctions to share/julia/base etc instead of Cygwin symlinks #7752

Merged
merged 1 commit into from
Jul 28, 2014

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Jul 28, 2014

I would've committed this straight to master if @StefanKarpinski hadn't just reverted a feature addition.

This switches from using Cygwin symlinks, which only Cygwin applications can read, to NTFS junctions (as we're using in the MSYS build) for share/julia/base, share/julia/doc, and share/julia/examples, and share/julia/test. This allows the from-source Julia build in a Cygwin-to-MinGW cross-compile to reference files with the same paths relative to JULIA_HOME as a binary install.

@JeffBezanson
Copy link
Member

Strikes me as more of a fix than a new feature.

@Keno
Copy link
Member

Keno commented Jul 28, 2014

Agreed. LGTM.

Keno added a commit that referenced this pull request Jul 28, 2014
Use NTFS junctions to share/julia/base etc instead of Cygwin symlinks
@Keno Keno merged commit 8b743d1 into JuliaLang:master Jul 28, 2014
@tkelman tkelman deleted the cygwin-buildfix branch July 28, 2014 07:44
@tkelman
Copy link
Contributor Author

tkelman commented Jul 28, 2014

Alright, sorry for the noise then. Once I finish adopting the p7zip Cygwin package and getting it uploaded to 64-bit Cygwin (needed for make dist), I'll add a section to README.windows.md documenting the Cygwin-to-MinGW cross-compile steps and required packages. It's been working reliably for me, and IMO it's a bit easier to set up than MSYS2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants