Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added promotion to
map
– if the nextf(x)
doesn't fit into the result array, the array type is promoted. This will fix things likemap(join, ["z", "я"])
. Equally, functions that can returnInt
s andFloat
s will promote toFloat
rather than trying to cast everything toInt
(and producingInexactError
s).Performance in cases that already work should be largely unaffected; in almost all other cases, the promotion will only happen once. #210 still needs fixing for ideal performance, but at least this way
map
is functional in both senses.(The worst case performance hit – for a small function over an
Int
array – is about 2x.)In order to make this work I had to extend
copy!
to support undefined values, as well as making it more flexible so that it gets called instead of the genericcopy!(dest::AbstractArray, src)
.By the way, why are there map definitions for 1, 2, and multiple args? Wouldn't the N arg version suffice?