allow apply_type_tfunc to handle argtypes with Union
#56617
+75
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/union-apply_type
branch
from
dcd8170
to
c6fde6d
Compare
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
vtjnash
reviewed
Nov 20, 2024
vtjnash
reviewed
Nov 20, 2024
aviatesk
force-pushed
the
avi/union-apply_type
branch
2 times, most recently
from
3b35cae
to
adabb1e
Compare
This is an alternative to #56532 and can resolve #31909. Currently `apply_type_tfunc` is unable to handle `Union`-argtypes with any precision. With this change, `apply_type_tfunc` now performs union-splitting on `Union`-argtypes and returns the merged result of the splits. While this can improve inference precision, we might need to be cautious about potential inference time bloat.
Co-authored-by: Jameson Nash <[email protected]>
aviatesk
force-pushed
the
avi/union-apply_type
branch
from
adabb1e
to
57aa8e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #56532 and can resolve #31909. Currently
apply_type_tfuncis unable to handleUnion-argtypes with any precision. With this change,apply_type_tfuncnow performs union-splitting onUnion-argtypes and returns the merged result of the splits.While this can improve inference precision, we might need to be cautious about potential inference time bloat.