irinterp: set IR_FLAG_REFINED for narrowed PhiNodes
#56391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`adce_pass!` can transform a `Union`-type `PhiNode` into a narrower `PhiNode`, but in such cases, the `IR_FLAG_REFINED` flag isn’t set on that `PhiNode` statement. By setting this flag, irinterp can perform statement reprocessing using the narrowed `PhiNode`, enabling type stability in cases like #56387. - fixes #56387
|
Is this backportable? |
|
Yeah, probably backportable up to the point where we defined |
|
So I just tried to build |
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adce_pass!can transform aUnion-typePhiNodeinto a narrowerPhiNode, but in such cases, theIR_FLAG_REFINEDflag isn’t set on thatPhiNodestatement. By setting this flag, irinterp can perform statement reprocessing using the narrowedPhiNode, enabling type stability in cases like #56387.NamedTuplewith one field, but succeeds for larger named tuples #56387