fix precompile process flags #56214
Merged
fix precompile process flags #56214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,8 @@ print-depot-path: | |||
| @$(call PRINT_JULIA, $(call spawn,$(JULIA_EXECUTABLE)) --startup-file=no -e '@show Base.DEPOT_PATH') | |||
|
|
|||
| $(BUILDDIR)/stdlib/%.image: $(JULIAHOME)/stdlib/Project.toml $(JULIAHOME)/stdlib/Manifest.toml $(INDEPENDENT_STDLIBS_SRCS) $(JULIA_DEPOT_PATH)/compiled | |||
| @$(call PRINT_JULIA, JULIA_CPU_TARGET="$(JULIA_CPU_TARGET)" $(call spawn,$(JULIA_EXECUTABLE)) --startup-file=no -e 'Base.Precompilation.precompilepkgs(;configs=[``=>Base.CacheFlags(), `--check-bounds=yes`=>Base.CacheFlags(;check_bounds=1)])') | |||
| @$(call PRINT_JULIA, JULIA_CPU_TARGET="$(JULIA_CPU_TARGET)" $(call spawn,$(JULIA_EXECUTABLE)) --startup-file=no -e \ | |||
| 'Base.Precompilation.precompilepkgs(configs=[``=>Base.CacheFlags(debug_level=2, opt_level=3), ``=>Base.CacheFlags(check_bounds=1, debug_level=2, opt_level=3)])') | |||
There was a problem hiding this comment.
The left part of the pair is used to annotate the process configurations in the precompilepkgs status, so needs to be meaningfully set.
There was a problem hiding this comment.
Oof, that seems like a mistake. I'll update to fix the printing
|
Could this also be #56177? |
vtjnash
force-pushed
the
jn/pkgimage-missing-opts
branch
from
75f498e
to
e2d3c5a
Compare
At a quick glance, that seems to be already fixed on |
CacheFlags could get set, but were never propagated to the target process, so the result would be unusable. Additionally, the debug and optimization levels were not synchronized with the sysimg, causing a regression in pkgimage usability after moving out stdlibs. The printing also failed to meaningfully represent the settings for the same reasons. Also fixes a concurrency bug in loading.jl tests that was failing. Fixes #56207 Fixes #56054 Fixes #56206
vtjnash
force-pushed
the
jn/pkgimage-missing-opts
branch
from
e2d3c5a
to
7b97822
Compare
|
For review-sake it now looks like this after this PR
|
KristofferC
reviewed
Oct 21, 2024
| @@ -677,7 +705,7 @@ function precompilepkgs(pkgs::Vector{String}=String[]; | |||
| n_print_rows = 0 | |||
| while !printloop_should_exit | |||
| lock(print_lock) do | |||
| term_size = Base.displaysize_(io) | |||
There was a problem hiding this comment.
This is not needed because io is now inferred?
There was a problem hiding this comment.
correct, io is now concrete
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
CacheFlags could get set, but were never propagated to the target process, so the result would be unusable. Additionally, the debug and optimization levels were not synchronized with the sysimg, causing a regression in pkgimage usability after moving out stdlibs. Fixes #56207 Fixes #56054 Fixes #56206 (cherry picked from commit 82b1506)
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
CacheFlags could get set, but were never propagated to the target process, so the result would be unusable. Additionally, the debug and optimization levels were not synchronized with the sysimg, causing a regression in pkgimage usability after moving out stdlibs. Fixes #56207 Fixes #56054 Fixes #56206
maleadt
pushed a commit
that referenced
this pull request
Oct 21, 2024
CacheFlags could get set, but were never propagated to the target process, so the result would be unusable. Additionally, the debug and optimization levels were not synchronized with the sysimg, causing a regression in pkgimage usability after moving out stdlibs. Fixes #56207 Fixes #56054 Fixes #56206 (cherry picked from commit 82b1506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheFlags could get set, but were never propagated to the target process, so the result would be unusable. Additionally, the debug and optimization levels were not synchronized with the sysimg, causing a regression in pkgimage usability after moving out stdlibs.
Fixes #56207
Fixes #56054
Fixes #56206
@vchuravy is this the intent for debug flags, or is a stripped binary supposed to be a different cache entry? If not, would you accept it if we compiled with
-gsplit-dwarf? https://gcc.gnu.org/wiki/DebugFission