Add atol to addmul tests
#56210
Merged
Add atol to addmul tests
#56210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures should be fixed by #55984 |
jishnub
force-pushed
the
jishnub/addmul_atol
branch
from
ac969c1
to
870d210
Compare
dkarrasch
approved these changes
Oct 25, 2024
jishnub
force-pushed
the
jishnub/addmul_atol
branch
from
870d210
to
e1d1c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the issues as in JuliaLang/LinearAlgebra.jl#1093 and JuliaLang/LinearAlgebra.jl#1092 where we compare small numbers using a relative tolerance. Also, in this PR, I have added an extra test, so now we compare both
A * B * alpha + C * betaandA * B * alpha - C * betawith the corresponding in-place versions. The idea is that if the termsA * B * alphaandC * betahave similar magnitudes, at least one of the two expressions will usually result in a large enough number that may be compared using a relative tolerance.I am unsure if the
atolchosen here is optimal, as I have ballparked it to use the maximumepsby looking at all theeltypes involved.Fixes JuliaLang/LinearAlgebra.jl#1093
Fixes JuliaLang/LinearAlgebra.jl#1092