Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit convert(String, ...) in several places #56174

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix implicit convert(String, ...) in several places #56174

merged 1 commit into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Fix implicit convert(String, ...) in several places 

    This code was already written very carefully. However, it assumed that
`for x::T in vec` is type-asserting, but it is actually implicitly
converting (what a painful subtlety)

This removes several `convert(String, ...)` from this code, which really
shouldn't be something we invalidate on in the first place but this is
still an improvement in code quality so let's take it.
    @topolarity
    topolarity committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ede21d2 View commit details
    Browse the repository at this point in the history